gsk: Remove GskRenderNode::hidden

If you want to hide something, don't render it.

diff --git a/docs/reference/gsk/gsk4-sections.txt b/docs/reference/gsk/gsk4-sections.txt
index b8c687b9b3380fb2f1ae01eea2a557a34d8b5974..4a226aa42bdeb619c0129bdefd36e2621f6d0a33 100644 (file)
--- a/docs/reference/gsk/gsk4-sections.txt
+++ b/docs/reference/gsk/gsk4-sections.txt
@@ -45,8 +45,6 @@ gsk_render_node_contains
 gsk_render_node_set_bounds
 gsk_render_node_set_transform
 gsk_render_node_set_opacity
-gsk_render_node_set_hidden
-gsk_render_node_is_hidden
 gsk_render_node_set_opaque
 gsk_render_node_is_opaque
 gsk_render_node_get_draw_context

diff --git a/gsk/gskcairorenderer.c b/gsk/gskcairorenderer.c
index 4c9dfef803111f2c988ec898c0cf021078f645e7..9b333c58670d9bd0b21ec7ac26098ce267e24ce3 100644 (file)
--- a/gsk/gskcairorenderer.c
+++ b/gsk/gskcairorenderer.c
@@ -59,9 +59,6 @@ gsk_cairo_renderer_render_node (GskCairoRenderer *self,
   cairo_matrix_t ctm;
   graphene_rect_t frame;
 
-  if (gsk_render_node_is_hidden (node))
-    return;
-
   cairo_save (cr);
 
   if (!gsk_render_node_has_surface (node) &&

diff --git a/gsk/gskglrenderer.c b/gsk/gskglrenderer.c
index c0d528871cc97959560cdf2a103f208ee5555214..ad03664de5613a69187994049e43f8f3390bbb03 100644 (file)
--- a/gsk/gskglrenderer.c
+++ b/gsk/gskglrenderer.c
@@ -636,14 +636,6 @@ gsk_gl_renderer_add_render_item (GskGLRenderer           *self,
   int program_id;
   int scale_factor;
 
-  if (gsk_render_node_is_hidden (node))
-    {
-      GSK_NOTE (OPENGL, g_print ("Skipping hidden node <%s>[%p]\n",
-                                 node->name != NULL ? node->name : "unnamed",
-                                 node));
-      return;
-    }
-
   memset (&item, 0, sizeof (RenderItem));
 
   gsk_renderer_get_viewport (GSK_RENDERER (self), &viewport);

diff --git a/gsk/gskrendernode.c b/gsk/gskrendernode.c
index 556a42e249257259a09377319889f90e8e1875f1..4f13ab619523de7fccd8e44dae77898101f925cc 100644 (file)
--- a/gsk/gskrendernode.c
+++ b/gsk/gskrendernode.c
@@ -1003,45 +1003,6 @@ gsk_render_node_get_opacity (GskRenderNode *node)
   return node->opacity;
 }
 
-/**
- * gsk_render_node_set_hidden:
- * @node: a #GskRenderNode
- * @hidden: whether the @node should be hidden or not
- *
- * Sets whether the @node should be hidden.
- *
- * Hidden nodes, and their descendants, are not rendered.
- *
- * Since: 3.90
- */
-void
-gsk_render_node_set_hidden (GskRenderNode *node,
-                            gboolean       hidden)
-{
-  g_return_if_fail (GSK_IS_RENDER_NODE (node));
-  g_return_if_fail (node->is_mutable);
-
-  node->hidden = !!hidden;
-}
-
-/**
- * gsk_render_node_is_hidden:
- * @node: a #GskRenderNode
- *
- * Checks whether a @node is hidden.
- *
- * Returns: %TRUE if the #GskRenderNode is hidden
- *
- * Since: 3.90
- */
-gboolean
-gsk_render_node_is_hidden (GskRenderNode *node)
-{
-  g_return_val_if_fail (GSK_IS_RENDER_NODE (node), TRUE);
-
-  return node->hidden;
-}
-
 /**
  * gsk_render_node_set_opaque:
  * @node: a #GskRenderNode

diff --git a/gsk/gskrendernode.h b/gsk/gskrendernode.h
index 7e4f530d65225a2c65499a2cf70c893f6abd701e..8e1f44b256e90fe46024386683e46589db4c0900 100644 (file)
--- a/gsk/gskrendernode.h
+++ b/gsk/gskrendernode.h
@@ -98,11 +98,6 @@ GDK_AVAILABLE_IN_3_90
 void                    gsk_render_node_set_opacity             (GskRenderNode *node,
                                                                  double         opacity);
 GDK_AVAILABLE_IN_3_90
-void                    gsk_render_node_set_hidden              (GskRenderNode *node,
-                                                                 gboolean       hidden);
-GDK_AVAILABLE_IN_3_90
-gboolean                gsk_render_node_is_hidden               (GskRenderNode *node);
-GDK_AVAILABLE_IN_3_90
 void                    gsk_render_node_set_opaque              (GskRenderNode *node,
                                                                  gboolean       opaque);
 GDK_AVAILABLE_IN_3_90

diff --git a/gsk/gskrendernodeprivate.h b/gsk/gskrendernodeprivate.h
index 2af53470693bc3435d77d7790894a0d1b346d773..01e1526f7eda1fdf9590665a246f1a5de4caccfa 100644 (file)
--- a/gsk/gskrendernodeprivate.h
+++ b/gsk/gskrendernodeprivate.h
@@ -58,7 +58,6 @@ struct _GskRenderNode
 
   /* Bit fields; leave at the end */
   gboolean is_mutable : 1;
-  gboolean hidden : 1;
   gboolean opaque : 1;
   gboolean transform_set : 1;
   gboolean needs_world_matrix_update : 1;

diff --git a/gsk/gskvulkanrenderpass.c b/gsk/gskvulkanrenderpass.c
index 1d493b152efc47a3bd957e884b7b233a738dbd63..892e9690aaca53713278d2b878214f6e05667f00 100644 (file)
--- a/gsk/gskvulkanrenderpass.c
+++ b/gsk/gskvulkanrenderpass.c
@@ -64,9 +64,6 @@ gsk_vulkan_render_pass_add_node (GskVulkanRenderPass *self,
     .node = node
   };
 
-  if (gsk_render_node_is_hidden (node))
-    return;
-
   if (gsk_render_node_get_opacity (node) < 1.0)
     goto fallback;
 

diff --git a/gtk/inspector/recorder.c b/gtk/inspector/recorder.c
index 1fe3c1cd7eba3e5e170261611af042c74a0fd086..25ddd0a7b73fb0d910b21e6acc864df420e74ddc 100644 (file)
--- a/gtk/inspector/recorder.c
+++ b/gtk/inspector/recorder.c
@@ -51,7 +51,6 @@ struct _GtkInspectorRecorderPrivate
 
 enum {
   COLUMN_NODE_NAME,
-  COLUMN_NODE_VISIBLE,
   /* add more */
   N_NODE_COLUMNS
 };
@@ -123,10 +122,6 @@ render_node_list_get_value (GtkTreeModelRenderNode *model,
       g_value_set_string (value, gsk_render_node_get_name (node));
       break;
 
-    case COLUMN_NODE_VISIBLE:
-      g_value_set_boolean (value, !gsk_render_node_is_hidden (node));
-      break;
-
     default:
       g_assert_not_reached ();
       break;
@@ -421,8 +416,7 @@ gtk_inspector_recorder_init (GtkInspectorRecorder *recorder)
 
   priv->render_node_model = gtk_tree_model_render_node_new (render_node_list_get_value,
                                                             N_NODE_COLUMNS,
-                                                            G_TYPE_STRING,
-                                                            G_TYPE_BOOLEAN);
+                                                            G_TYPE_STRING);
   gtk_tree_view_set_model (GTK_TREE_VIEW (priv->render_node_tree), priv->render_node_model);
   g_object_unref (priv->render_node_model);
 

diff --git a/gtk/inspector/recorder.ui b/gtk/inspector/recorder.ui
index 1ab80eedbfc34bff81666c239e0bde9da7f838db..b7fc96f20e18614ab1c4fff24af789d29e4bbd6f 100644 (file)
--- a/gtk/inspector/recorder.ui
+++ b/gtk/inspector/recorder.ui
@@ -93,7 +93,6 @@
                               <object class="GtkCellRendererText"/>
                               <attributes>
                                 <attribute name="text">0</attribute>
-                                <attribute name="sensitive">1</attribute>
                               </attributes>
                             </child>
                           </object>